NIFI-5430 CLI tool extension for cluster summary #2894
Conversation
| @@ -24,7 +24,7 @@ | |||
| * A serialized representation of this class can be placed in the entity body of a request or response to or from the API. This particular entity holds a reference to a ClusterSummaryDTO. | |||
| */ | |||
| @XmlRootElement(name = "clusterSummaryEntity") | |||
| public class ClusteSummaryEntity extends Entity { | |||
| public class ClusterSummaryEntity extends Entity { | |||
There was a problem hiding this comment.
I know this seems a bit nit-picky but I think we need to hold off renaming this class since we try to keep the nifi-client-dto backwards compatible between minor releases, and changing the name means any code written against this class would need to be updated, so I think we can hold off on that part and make that change during a major release like 2.0.0.
There was a problem hiding this comment.
I wasn't sure about that, so I created in a separate commit, reverting.
|
Hi @pepov can you please update the title of this PR to reference the NiFi Jira it resolves? Thanks. |
pepov
changed the title
|
Pushed a revert and fixed missing imports, however github seems to have issues, will trigger a new build later. |
| * | ||
| * @return cluster summary response | ||
| */ | ||
| ClusteSummaryEntity getClusterSummary() throws NiFiClientException, IOException; |
There was a problem hiding this comment.
This was still showing as missing import for me
| @@ -217,4 +217,12 @@ public ActivateControllerServicesEntity activateControllerServices(final Activat | |||
| ActivateControllerServicesEntity.class); | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| public ClusteSummaryEntity getClusterSummary() throws NiFiClientException, IOException { | |||
There was a problem hiding this comment.
Same import issue as above, also I assume the message should be "Error retrieving cluster summary" or something like that
|
had a hard time triggering a build with the import fixes due to github issues, sorry @bbende , it should be better now |
|
No problem, looks good and going to merge, thanks! |
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.