Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
NIFI-5442 Get X-ProxyContextPath value from request attributes rather… #2908
… than directly from headers.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
For all changes:
For code changes:
For documentation related changes:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
I can observe that passing a valid (whitelisted in nifi.properties:
I actually also don't have an instance set up with a proxy either. I've just been directly poking a simple unsecured NiFi instance (without a proxy) using
I guess I'd expect it to work like
If I add
I'd expect requests that use
(I'd embed the full shell text illustrating this but I don't have that available at this moment).
I poked around this issue a bit earlier today. I thought I tried exactly your fix (on top of 1.6.0 stable) and discovered that all message page renders were failing because of
It looked to me like we'd need to add something to
But I'm not sure. And perhaps there are other references to the message page that this wouldn't address.
Ok, I think I understand. When I do a remote debug, the
I believe there are some other locations in the code that forward requests to
This PR is not ready to be merged.
Thanks for the PR! I'm happy to help get this merged in. I tried out the proposed patch locally and it does address the issue in the case identified. However, I tried to run in some of the other context and the filter was not running as expected. Adding a dispatcher type of FORWARD on the