Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5083: enabled EL support for processor configuration of Kafka consumer group id #2913

Closed
wants to merge 1 commit into from

Conversation

snagafritz
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
I started to write unit tests for these changes then realized that the tests were really verifying the evaluation of the EL expressions, and I assume far better unit tests for this already exist. I will attach a video of me verifying expected behavior of a build of this branch to the JIRA ticket.
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@bbende
Copy link
Contributor

bbende commented Jul 25, 2018

I think you will also need to find where the group id property is used and ensure that evaluateAttributeExpressions() is called when obtaining the value.

@bbende
Copy link
Contributor

bbende commented Jul 25, 2018

Actually, I take back my last comment, I now see where the value is obtained and it does have the logic:

String propertyValue = propertyDescriptor.isExpressionLanguageSupported()
                    ? context.getProperty(propertyDescriptor).evaluateAttributeExpressions().getValue()
                    : context.getProperty(propertyDescriptor).getValue();

Sorry about that.

@zenfenan
Copy link
Contributor

Reviewing..

@zenfenan
Copy link
Contributor

+1 LGTM. Merged to master. Thanks @snagafritz

@zenfenan
Copy link
Contributor

@snagafritz Hey.. I forgot to close this PR while merging. It is now merged to the master. Can you manually close this PR?

@snagafritz snagafritz closed this Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants