NIFI-3425: Provide ability to cache CQL statements #2986
Conversation
| testRunner.setProperty(PutCassandraQL.STATEMENT_CACHE_SIZE, "1"); | ||
|
|
||
| testRunner.enqueue("INSERT INTO users (user_id, first_name, last_name, properties, bits, scaleset, largenum, scale, byteobject, ts) VALUES ?, ?, ?, ?, ?, ?, ?, ?, ?, ?", | ||
| new HashMap<String, String>() { |
There was a problem hiding this comment.
Is probably best to avoid the anonymous inner class and just use a HashMap and then call put() methods, no? It also appears to be the same values each time, so can create just a single HashMap and then pass it each time.
| @@ -399,11 +434,13 @@ protected void setStatementObject(final BoundStatement statement, final int para | |||
| @OnUnscheduled | |||
| public void stop() { | |||
| super.stop(); | |||
| statementCache.clear(); | |||
There was a problem hiding this comment.
Would recommend putting this into an @OnStopped method instead of @OnUnscheduled. As-is, we could get into a race condition where line 225 calls statementCache.get(), which returns null. Then the @OnUnscheduled method clears the cache, and then line 228 adds the value to the cache. Then, the next time this processor is run, the cache is already populated. Given that we are calling clear() here I'm assuming we expect it clear when the processor starts.
| } | ||
|
|
||
| @OnShutdown | ||
| public void shutdown() { | ||
| super.stop(); | ||
| statementCache.clear(); |
There was a problem hiding this comment.
Given that we're calling this when the processor is stopped, I don't think there's a need for it here.
There was a problem hiding this comment.
@mattyb149 when you make the changes that @markap14 wants you'll be +1 from me too.
Co-authored-by: Michael A Giroux <magirou@rd6ul-92373g.infosec.tycho.ncsc.mil>
mattyb149
force-pushed
the
NIFI-3425
branch
from
bc32c49
to
a774ed8
Compare
|
Thanks @mattyb149 , all looks good to me now. +1 merged to master. |
Co-authored-by: Michael A Giroux magirou@rd6ul-92373g.infosec.tycho.ncsc.mil
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.