New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIFI-5646] Dockerfile.alpine: Added. #3038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should also be a copy under dockermaven and the Maven build should be updated to have a profile for each that switches to using alpine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're moving in the right direction. Now we need some Maven profiles to do different builds.
@MikeThomsen Yes, I had a look at https://github.com/spotify/docker-maven-plugin when I had added the An alternative would be to put the |
@apiri What do you think?
I think a separate alpine build would be a nice thing to have. |
@MikeThomsen We (certain folks on the PMC) have some good flexibility with performing releases to Docker Hub. I think the Alpine addition is certainly fine and the tagging makes sense. Likely don't need the full breadth of offerings that JDK has (https://hub.docker.com/r/library/openjdk/tags/) but establishing a similar taxonomy would be my preference. That, in conjunction with helper scripts, would allow us to a bit more seamlessly automate this process for those that have push access to the repositories. |
closing due to inactivity |
This pull request adds a separate Dockerfile for an Alpine Linux based image.
This has a difference of ~0.4G compared to the normal Debian based image:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?