Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIFI-5646] Dockerfile.alpine: Added. #3038

Closed
wants to merge 2 commits into from
Closed

Conversation

jpds
Copy link

@jpds jpds commented Sep 28, 2018

This pull request adds a separate Dockerfile for an Alpine Linux based image.

This has a difference of ~0.4G compared to the normal Debian based image:

% docker images | grep nifi
nifi                             1.7.1-alpine         4f93b2311bdc        6 minutes ago       1.41GB
apache/nifi                      1.7.1                b5827934cd00        2 months ago        1.82GB

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

@jpds jpds changed the title [NIFI-5646] nifi-docker/dockerhub/Dockerfile.alpine: Added. [NIFI-5646] Dockerfile.alpine: Added. Sep 28, 2018
Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be a copy under dockermaven and the Maven build should be updated to have a profile for each that switches to using alpine.

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're moving in the right direction. Now we need some Maven profiles to do different builds.

@jpds
Copy link
Author

jpds commented Oct 4, 2018

@MikeThomsen Yes, I had a look at https://github.com/spotify/docker-maven-plugin when I had added the dockermaven image but I couldn't find a way from the documentation to give the plugin the different Dockerfile image (akin to the -f flag of docker build) (I'm not a Maven expert either).

An alternative would be to put the Dockerfiles into subdirectories if the above is a limitation in the plugin.

@MikeThomsen
Copy link
Contributor

MikeThomsen commented Nov 24, 2018

@apiri What do you think?

An alternative would be to put the Dockerfiles into subdirectories if the above is a limitation in the plugin.

I think a separate alpine build would be a nice thing to have.

@apiri
Copy link
Member

apiri commented Nov 24, 2018

@MikeThomsen We (certain folks on the PMC) have some good flexibility with performing releases to Docker Hub. I think the Alpine addition is certainly fine and the tagging makes sense. Likely don't need the full breadth of offerings that JDK has (https://hub.docker.com/r/library/openjdk/tags/) but establishing a similar taxonomy would be my preference. That, in conjunction with helper scripts, would allow us to a bit more seamlessly automate this process for those that have push access to the repositories.

@joewitt
Copy link
Contributor

joewitt commented Mar 25, 2021

closing due to inactivity

@joewitt joewitt closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants