New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-6112: Add some useful commands to NiFi Toolkit for automating NiFi cluster construction. #3366
Conversation
…Fi cluster construction.
Wow, this looks like a very helpful feature for people setting up their NiFi instances. I haven't gotten a chance to do a full review yet, but some quick notes:
|
This looks really cool, thanks for contributing! I will definitely try to review this soon, unless Andy or someone else gets to it first. |
There is no such capability. I will add it. |
@alopresto |
I think there is definitely value to being able to specify the UUID as it is unique and clearly identifies the user objects. I just like the ability to use either value. Is it ok to support both? |
I understood. I will fix to support both. |
I fixed to support both UUID and identity for user / user group specification. I also added documentation and examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all of the commands, and overall this is awesome!
Left some comments of a few things that should be considered before we merge this in. Thanks!
...src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/policies/UpdateAccessPolicy.java
Outdated
Show resolved
Hide resolved
...lkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/result/UsersResult.java
Show resolved
Hide resolved
...nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/result/UserGroupsResult.java
Show resolved
Hide resolved
...src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/policies/UpdateAccessPolicy.java
Outdated
Show resolved
Hide resolved
...li/src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/cs/GetControllerServices.java
Show resolved
Hide resolved
...olkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/result/ControllerServiceResult.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/cs/CreateControllerService.java
Show resolved
Hide resolved
...li/src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/flow/CreateReportingTask.java
Show resolved
Hide resolved
...-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/result/ReportingTasksResult.java
Show resolved
Hide resolved
.../src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/templates/DownloadTemplate.java
Show resolved
Hide resolved
…Policy. (with slight refactoring)
…s for reporting task controller service. Also added "get-repoting-task" command (for single reporting task) to be consistent with controller service.
@bbende |
Changes look good! Thanks for addressing the feedback and for contributing all of this, going to merge |
Thank you for reviewing and merging it! |
…Fi cluster construction. - Supports both UUID and identity for user / user group specification - Add UUID to toolkit command results - Fix representation for type and bundle of ControllerServiceResult - Make description more detailed - Fix to print only in interactive mode or verbose mode in UpdateAccessPolicy. (with slight refactoring) - Add list-templates command - Add start/stop commands for reporting task and enable/disable commands for reporting task controller service. - Also added "get-repoting-task" command (for single reporting task) to be consistent with controller service. This closes apache#3366. Signed-off-by: Bryan Bende <bbende@apache.org>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.