Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6112: Add some useful commands to NiFi Toolkit for automating NiFi cluster construction. #3366

Closed
wants to merge 8 commits into from

Conversation

yoshiata
Copy link
Contributor

@yoshiata yoshiata commented Mar 12, 2019

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Contributor

Wow, this looks like a very helpful feature for people setting up their NiFi instances. I haven't gotten a chance to do a full review yet, but some quick notes:

  • For anyone else doing a review, there is extensive documentation and examples in the Jira - NIFI-6112
  • In the examples, the command to add a user to a group specifies the UUID of the user, rather than the identity (aka user1). Is there also a capability to do it by identity (i.e. % ./cli.sh nifi create-user-group --userGroupName admin --userList user1)?

@bbende
Copy link
Contributor

bbende commented Mar 12, 2019

This looks really cool, thanks for contributing!

I will definitely try to review this soon, unless Andy or someone else gets to it first.

@yoshiata
Copy link
Contributor Author

@alopresto

Is there also a capability to do it by identity (i.e. % ./cli.sh nifi create-user-group --userGroupName admin --userList user1)?

There is no such capability. I will add it.

@yoshiata
Copy link
Contributor Author

yoshiata commented Mar 14, 2019

@alopresto
Since UUID is difficult to use, I will fix not to use UUID to specify users and user groups. (use only the identity.) Is that okay?
(However, since the controller service may have duplicate names, specify it by UUID.)

@alopresto
Copy link
Contributor

I think there is definitely value to being able to specify the UUID as it is unique and clearly identifies the user objects. I just like the ability to use either value. Is it ok to support both?

@yoshiata
Copy link
Contributor Author

I understood. I will fix to support both.

@yoshiata
Copy link
Contributor Author

I fixed to support both UUID and identity for user / user group specification.
16905fc

I also added documentation and examples.
https://issues.apache.org/jira/browse/NIFI-6112?focusedCommentId=16793259&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16793259

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all of the commands, and overall this is awesome!

Left some comments of a few things that should be considered before we merge this in. Thanks!

@yoshiata
Copy link
Contributor Author

yoshiata commented Mar 20, 2019

@bbende
Thank you for reviewing the last commit.
I updated the PR based on your reviews. Please review.

@bbende
Copy link
Contributor

bbende commented Mar 29, 2019

Changes look good! Thanks for addressing the feedback and for contributing all of this, going to merge

@asfgit asfgit closed this in 3696b5b Mar 29, 2019
@yoshiata
Copy link
Contributor Author

yoshiata commented Apr 1, 2019

Thank you for reviewing and merging it!

@yoshiata yoshiata deleted the NIFI-6112 branch April 1, 2019 00:35
rwithers pushed a commit to rwithers/nifi that referenced this pull request May 3, 2019
…Fi cluster construction.

- Supports both UUID and identity for user / user group specification
- Add UUID to toolkit command results
- Fix representation for type and bundle of ControllerServiceResult
- Make description more detailed
- Fix to print only in interactive mode or verbose mode in UpdateAccessPolicy. (with slight refactoring)
- Add list-templates command
- Add start/stop commands for reporting task and enable/disable commands for reporting task controller service.
- Also added "get-repoting-task" command (for single reporting task) to be consistent with controller service.

This closes apache#3366.

Signed-off-by: Bryan Bende <bbende@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants