Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6122: PutS3Object supports national characters in filenames. #3373

Closed
wants to merge 1 commit into from

Conversation

turcsanyip
Copy link
Contributor

@turcsanyip turcsanyip commented Mar 14, 2019

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak
Copy link
Member

Reviewing...

@ijokarumawak
Copy link
Member

Thanks @turcsanyip for fixing this! I confirmed Japanese characters can be used as a filename. Merging to master!

image

@asfgit asfgit closed this in 77b84ed Mar 20, 2019
asfgit pushed a commit that referenced this pull request Apr 1, 2019
This closes #3373.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
asfgit pushed a commit that referenced this pull request Apr 3, 2019
This closes #3373.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
rwithers pushed a commit to rwithers/nifi that referenced this pull request May 3, 2019
This closes apache#3373.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants