NIFI-6468: Adding AWS S3 'requester pays' to Fetch and List processors. #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turcsanyip
requested changes
Jul 25, 2019
There was a problem hiding this comment.
@gresockj Thank you for your contribution!
I have tested it on S3 and it works fine.
I have found one improvement point regarding validation of the ListS3 processor config, and also a minor code refinement in the tests.
...abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java
Outdated
Show resolved
Hide resolved
...e/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestFetchS3Object.java
Outdated
Show resolved
Hide resolved
gresockj
force-pushed
the
NIFI-6468
branch
3 times, most recently
from
346d0b2
to
cf6e2bf
Compare
pvillard31
approved these changes
Aug 13, 2019
|
+1 from me as well, merging to master, thanks @gresockj |
tpalfy
pushed a commit
to tpalfy/nifi
that referenced
this pull request
Aug 21, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#3601.
szaboferee
pushed a commit
to szaboferee/nifi
that referenced
this pull request
Oct 7, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#3601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
NIFI-6468: Adds "requester pays" to FetchS3Object and ListS3.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.