Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6647 - Upgrading Apache Ignite version to 2.8.0 #3720

Closed

Conversation

matthew-formosa-gig
Copy link
Contributor

@matthew-formosa-gig matthew-formosa-gig commented Sep 11, 2019

Description of PR

The version of Apache Ignite is currently set to 1.6.0 which is now over 3 years old. Upgrading to the latest version, that is 2.8.0.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?

@matthew-formosa-gig matthew-formosa-gig changed the title Nifi 6647 - Upgrading Apache Ignite version to 2.7.5 NIFI-6647 - Upgrading Apache Ignite version to 2.7.5 Sep 11, 2019
@matthew-formosa-gig matthew-formosa-gig changed the title NIFI-6647 - Upgrading Apache Ignite version to 2.7.5 NIFI-6647 - Upgrading Apache Ignite version to 2.7.6 Sep 28, 2019
@matthew-formosa-gig
Copy link
Contributor Author

@jtstorck could you please review this by any chance? Saw you had other PRs related to Apache Ignite.

@joewitt
Copy link
Contributor

joewitt commented Oct 8, 2019

@matthew-formosa-gig can you find out what is creating

Untracked files:
(use "git add ..." to include in what will be committed)
nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/ignite/

It should create directories under target so it is cleanly handled during the build process and properly ignored in terms of source/etc..

otherwise this looks ready to roll. I could build fine on java8 and java 11 and the travis issues weren't related to this PR so otherwise it is ready

@joewitt
Copy link
Contributor

joewitt commented Oct 8, 2019

@matthew-formosa-gig the ignite folks leave a quite nice readme in there

This is Apache Ignite working directory that contains information that
Ignite nodes need in order to function normally.
Don't delete it unless you're sure you know what you're doing.

You can change the location of working directory with
igniteConfiguration.setWorkingDirectory(location) or
in IgniteConfiguration .
README.txt (END)

@matthew-formosa-gig
Copy link
Contributor Author

Thanks for your feedback. Successfully redirected work directory to target folder.

@matthew-formosa-gig
Copy link
Contributor Author

@joewitt Kind reminder with regards to this PR.

@matthew-formosa-gig matthew-formosa-gig changed the title NIFI-6647 - Upgrading Apache Ignite version to 2.7.6 NIFI-6647 - Upgrading Apache Ignite version to 2.8.0 May 7, 2020
@matthew-formosa-gig
Copy link
Contributor Author

@joewitt It's been a while :) Upgraded to Apache Ignite 2.8.0. Tests are successful locally, not sure why some seem to be failing on ci-workflow.

@matthew-formosa-gig
Copy link
Contributor Author

matthew-formosa-gig commented May 15, 2020

#4278 includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants