New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-6550: Create controller service for Azure Storage Credentials #3742
Conversation
Added AzureStorageCredentialsService controller service interface with 2 implementations: - AzureStorageCredentialsControllerService: holds the credential properties (account name, account key, sas token) - AzureStorageCredentialsControllerServiceLookup: can be used to dynamically look up another AzureStorageCredentialsService (similar to DBCPConnectionPoolLookup) The controller service can be used by the Azure Storage processors: {List|Fetch|Put|Delete}AzureBlobStorage, {Get|Put}AzureQueueStorage
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Show resolved
Hide resolved
.../src/main/java/org/apache/nifi/processors/azure/storage/queue/AbstractAzureQueueStorage.java
Outdated
Show resolved
Hide resolved
...rocessors/src/test/java/org/apache/nifi/processors/azure/storage/AbstractAzureStorageIT.java
Outdated
Show resolved
Hide resolved
...ocessors/src/test/java/org/apache/nifi/services/azure/storage/MockAzureStorageProcessor.java
Outdated
Show resolved
Hide resolved
...e/nifi/processors/azure/storage/utils/TestAzureStorageUtilsGetStorageCredentialsDetails.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly look good to me as well, but posted few minor comments to make it even better. Nice unit test coverage, thanks @turcsanyip !
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessor.java
Outdated
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Outdated
Show resolved
Hide resolved
@ijokarumawak Thanks for the review! I implemented your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! Thanks for the further improvement @turcsanyip . I'll fix the description a little bit when merging (see another comment). LGTM +1! Going to squash and merge!
.description(ACCOUNT_NAME_BASE_DESCRIPTION + | ||
" Instead of defining the Storage Account Name, Storage Account Key and SAS Token properties directly on the processor, " + | ||
"the preferred way is to configure them through a controller service specified in the Storage Credentials property. " + | ||
"The controller service can provide a common/shared configuration for multiple/all AWS processors. Furthermore, the credentials " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll replace 'AWS' to 'Azure' when merging it :)
Added AzureStorageCredentialsService controller service interface with 2 implementations: - AzureStorageCredentialsControllerService: holds the credential properties (account name, account key, sas token) - AzureStorageCredentialsControllerServiceLookup: can be used to dynamically look up another AzureStorageCredentialsService (similar to DBCPConnectionPoolLookup) The controller service can be used by the Azure Storage processors: {List|Fetch|Put|Delete}AzureBlobStorage, {Get|Put}AzureQueueStorage NIFI-6550: Review changes. NIFI-6550: Review changes apache#2. This closes apache#3742. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Added AzureStorageCredentialsService controller service interface with 2 implementations: - AzureStorageCredentialsControllerService: holds the credential properties (account name, account key, sas token) - AzureStorageCredentialsControllerServiceLookup: can be used to dynamically look up another AzureStorageCredentialsService (similar to DBCPConnectionPoolLookup) The controller service can be used by the Azure Storage processors: {List|Fetch|Put|Delete}AzureBlobStorage, {Get|Put}AzureQueueStorage NIFI-6550: Review changes. NIFI-6550: Review changes #2. This closes apache#3742. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Added AzureStorageCredentialsService controller service interface
with 2 implementations:
(account name, account key, sas token)
look up another AzureStorageCredentialsService (similar to
DBCPConnectionPoolLookup)
The controller service can be used by the Azure Storage processors:
{List|Fetch|Put|Delete}AzureBlobStorage, {Get|Put}AzureQueueStorage
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.