Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6583: adding azure log analytics reporting task to nifi-azure-bu… #3817

Closed
wants to merge 2 commits into from

Conversation

sjyang18
Copy link
Contributor

Description of PR

NIFI-6583: adding azure log analytics reporting task to nifi-azure-bundle

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@markap14 markap14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjyang18 thanks for the contribution! The logic generally looks straight forward, but I think there's some code cleanup / conventions that we try to follow that are missing a bit in this PR. We try to keep the code fairly consistent across the codebase to make it easier to maintain, as there are quite a lot of contributors at this point. I left more detailed comments inline. Please take a look. Thanks again!

@sjyang18
Copy link
Contributor Author

@markap14 I just want to remind you of my update according to your feedback. When you get a chance, would you review my pull request again? Thanks

@sjyang18
Copy link
Contributor Author

@markap14 Would you review my pull request and see if anything I need to address?

@markap14
Copy link
Contributor

Sorry for the delay @sjyang18. I looked over the code and all looks good. Will want to do some testing before merging, so it will likely be a day or two before I'm able to get everything setup for that. I'll also want to double-check that the LICENSE and NOTICE files are in good shape, but assuming that I don't run into any issues, I think I should be able to get this merged in this week. Thanks!

@asfgit asfgit closed this in 0acdde8 Nov 21, 2019
@markap14
Copy link
Contributor

Thanks @sjyang18 I was able to test and verify that everything is working. +1 merged to master.

patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
…ndle

This closes apache#3817.

Signed-off-by: Mark Payne <markap14@hotmail.com>
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
…ndle

This closes apache#3817.

Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants