New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-6583: adding azure log analytics reporting task to nifi-azure-bu… #3817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjyang18 thanks for the contribution! The logic generally looks straight forward, but I think there's some code cleanup / conventions that we try to follow that are missing a bit in this PR. We try to keep the code fairly consistent across the codebase to make it easier to maintain, as there are quite a lot of contributors at this point. I left more detailed comments inline. Please take a look. Thanks again!
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-reporting-task/pom.xml
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
...orting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestVerification.java
Outdated
Show resolved
Hide resolved
...orting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestVerification.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/nifi/reporting/azure/loganalytics/AzureLogAnalyticsReportingTask.java
Outdated
Show resolved
Hide resolved
@markap14 I just want to remind you of my update according to your feedback. When you get a chance, would you review my pull request again? Thanks |
@markap14 Would you review my pull request and see if anything I need to address? |
Sorry for the delay @sjyang18. I looked over the code and all looks good. Will want to do some testing before merging, so it will likely be a day or two before I'm able to get everything setup for that. I'll also want to double-check that the LICENSE and NOTICE files are in good shape, but assuming that I don't run into any issues, I think I should be able to get this merged in this week. Thanks! |
Thanks @sjyang18 I was able to test and verify that everything is working. +1 merged to master. |
…ndle This closes apache#3817. Signed-off-by: Mark Payne <markap14@hotmail.com>
…ndle This closes apache#3817. Signed-off-by: Mark Payne <markap14@hotmail.com>
Description of PR
NIFI-6583: adding azure log analytics reporting task to nifi-azure-bundle
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.