Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6803 - ActionHandler Controller Services #3856

Closed
wants to merge 1 commit into from

Conversation

YolandaMDavis
Copy link
Contributor

NIFI-6803 - updated to description

NIFI-6803 - add Spring reference to Notice

This PR provide default Action Handlers for Rules as Controller Services. Action Handlers included are:

LogHandler - Executes Logging Actions
ExpressionHandler - Execute MVEL or SpEL Expressions
RecordSinkHandler - Executes Actions that require Records to be Sent via Record Sink
ActionHandlerLookup - Provides a dynamic method for tying Action types to an Action Handler (e.g. a 'LOG' action type can align with the LogHandler service, 'SEND' to RecordSinkHandler, etc)

Attached is an example or how things can be invoked with an InvokedScriptedProcessor with the ActionHandlerLookup service used to invoke other handlers, however this test should also allow use of the individual handlers (and report when handlers can not support the provided action).

rules-test.zip

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

NIFI-6803 - updated to description

NIFI-6803 - add Spring reference to Notice
@mattyb149
Copy link
Contributor

Reviewing...

@mattyb149
Copy link
Contributor

+1 LGTM, ran contrib-check and tried some sample flows with various action handler configurations. Thanks for this addition! Merging to master

@asfgit asfgit closed this in 5b28f6d Nov 1, 2019
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
NIFI-6803 - updated to description

NIFI-6803 - add Spring reference to Notice

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#3856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants