NIFI-6833 KeytabCredentialsService updated to qualify a principal wit…

[jtstorck]

…h an instance

Added feature to NiFi's TestRunner to allow a NiFiProperties instance to be specified for controller services that are added to the TestRunner
Added dependency on nifi-mock to the nifi-kerberos-credentials-service module for testing
Added instance and shortname parsing to KerberosPrincipalParser

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

KeytabCredentialsService can now qualify a principal with an instance.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• Have you verified that the full build is successful on both JDK 8 and JDK 11?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[bbende]

I'm wondering it it makes sense to use NiFiProperties with in the mock framework. I know it that is how the running application obtains the kerberos properties, but it feels like the mock framework shouldn't have to really use NiFiProperties.

What do you think about this approach...

• Implement a class MockKerberosContext that implements KerberosContext
• Add a member variable of KerberosContext to StandardProcessorTestRunner
• Add a new constructor to StandardProcessorTestRunner that allows you to pass in a KerberosContext
• Add a new overload factory method to TestRunners that allows passing in a KerberosContext
• In StandardProcessorTestRunner, whenever a MockControllerServiceInitializationContext is created, pass in the KerberosContext that was set, and have it delegate to that

[github-actions]

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.