NIFI-6957: PublishJMS - Added option to REGEX attributes #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, I left in unused imports. I've removed these and pushed the changes |
pvillard31
requested changes
Dec 26, 2019
There was a problem hiding this comment.
Hey @r65535 - thanks for the contribution. I left some comments.
...e/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/AbstractJMSProcessor.java
Outdated
Show resolved
Hide resolved
...e/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/AbstractJMSProcessor.java
Outdated
Show resolved
Hide resolved
...e/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/AbstractJMSProcessor.java
Outdated
Show resolved
Hide resolved
|
@pvillard31 - thanks for reviewing. I've made the changes you've requested, and repushed to my branch. |
pvillard31
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Looks good to me @r65535 - thanks for the changes. Merging to master.
patricker
pushed a commit
to patricker/nifi
that referenced
this pull request
Jan 22, 2020
…chars in header names Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#3942.
natural
pushed a commit
to natural/nifi
that referenced
this pull request
Feb 1, 2020
…chars in header names Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#3942.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of publishing all attributes as headers to the JMS broker, I've added an option to REGEX the headers the user wants to send.
I've also added an option to allow illegal characters in header names (hyphens and full stops), as some JMS broker implementations allow this.
The default values have been kept the same, so functionality will stay the same for end users.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.