NIFI-6915 Jms Durable non shared subscription is broken

[gardellajuanpablo]

Revert NIFI-4834 enhancement for durable non shared consumers only.

Updated also AbstractJMSProcessor class to be public. The testing are not working
without that change, as org.apache.nifi.jms.processors.PublishJMSIT and
org.apache.nifi.jms.processors.ConsumeJMSIT are not working, as @onschedule
method is not called (because it is not public).
The method org.apache.nifi.util.StandardProcessorTestRunner.run(int iterations, boolean stopOnFinish, boolean initialize, long runWait) uses ReflectionUtils.invokeMethodsWithAnnotation which does not call non public
methods.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• Have you verified that the full build is successful on both JDK 8 and JDK 11?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[m-hogue]

I believe you have a typo here. I think the logic should be context.getMaxConcurrentTasks() > 1 && isDurableSubscriber(context) && !isShared(context). As is, this condition would never be satisfied.

Can you please add a unit test verifying this new behavior? Also, is it possible to add unit test(s) to verify that the issue you're trying to address (changing client IDs for durable non-shared clients on processor restart) is resolved?

[gardellajuanpablo]

You are right, thank you. I will push the fix.

[gardellajuanpablo]

Fixed and added unit tests to verify the behavior. You can check without this fix, the unit test will miss a message.

[pvillard31]

Hi @gardellajuanpablo - this needs to be rebased against master

[gardellajuanpablo]

Hi @gardellajuanpablo - this needs to be rebased against master

Done, I had some troubles to apply rebase. Hope it is ok now.

[joewitt]

travis is green on all builds. local build almost done. reviewed code - looks good. will merge to master shortly - thanks