Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7101: PivotDatabaseRecordLookupService: add new lookup service which pivot a key/value table #4037

Closed
wants to merge 3 commits into from

Conversation

CZuegner
Copy link
Contributor

@CZuegner CZuegner commented Feb 4, 2020

Example:

Database Table

ID KEY_COL VAL_COL
1 A One
1 B Two

Result Record for Lookup Key 1

map
{A=One, B=Two}

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@CZuegner
Copy link
Contributor Author

CZuegner commented Feb 5, 2020

This pull-request depends on PR NIFI-7099. If NIFI-7099 is merge I will update this PR.

…ect Statement alternatively to table name and key column

This alternative way enables the following use-cases:
- When more than one column are required to identify the record in the database
- When joining multiple tables is nesessary but creating a view in the database is not an option
…hich pivot a key/value table

Example:

Database Table

+----+---------+---------+
| ID | KEY_COL | VAL_COL |
+----+---------+---------+
|  1 |       A |     One |
|  1 |       B |     Two |
+----+---------+---------+

Result Record for Lookup Key 1

+----------------+
|            map |
+----------------+
| {A=One, B=Two} |
+----------------+
@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Apr 25, 2021
@github-actions github-actions bot closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant