Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-4970 - EOF Exception in InvokeHttp when body's response is empty with gzip #4109

Closed
wants to merge 3 commits into from
Closed

NIFI-4970 - EOF Exception in InvokeHttp when body's response is empty with gzip #4109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95ac814
Create testEmptyGzipHttpReponse
eduardofontes Mar 4, 2020
230d297
Tests properly if content body exists.
eduardofontes Mar 4, 2020
fc2b81e
Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors…
pvillard31 Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
View file
Open in desktop
Expand Up @@ -842,7 +842,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
boolean outputBodyToRequestAttribute = (!isSuccess(statusCode) || putToAttribute) && requestFlowFile != null;
boolean outputBodyToResponseContent = (isSuccess(statusCode) && !putToAttribute) || context.getProperty(PROP_OUTPUT_RESPONSE_REGARDLESS).asBoolean();
ResponseBody responseBody = responseHttp.body();
boolean bodyExists = responseBody != null;
boolean bodyExists = responseBody != null ? responseBody.contentLength() > 0 : false;

InputStream responseBodyStream = null;
SoftLimitBoundedByteArrayOutputStream outputStreamToRequestAttribute = null;
Expand Down
38 changes: 38 additions & 0 deletions ...standard-processors/src/test/java/org/apache/nifi/processors/standard/TestInvokeHTTP.java
View file
Open in desktop
Expand Up @@ -268,4 +268,42 @@ public void testOnPropertyModified() throws Exception {
assertNull(regexAttributesToSendField.get(processor));

}
@Test
public void testEmptyGzipHttpReponse() throws Exception {
addHandler(new EmptyGzipResponseHandler());

runner.setProperty(InvokeHTTP.PROP_URL, url);

createFlowFiles(runner);

runner.run();

runner.assertTransferCount(InvokeHTTP.REL_SUCCESS_REQ, 1);
runner.assertTransferCount(InvokeHTTP.REL_RESPONSE, 1);
runner.assertTransferCount(InvokeHTTP.REL_RETRY, 0);
runner.assertTransferCount(InvokeHTTP.REL_NO_RETRY, 0);
runner.assertTransferCount(InvokeHTTP.REL_FAILURE, 0);
runner.assertPenalizeCount(0);

//expected empty content in response FlowFile
final MockFlowFile bundle = runner.getFlowFilesForRelationship(InvokeHTTP.REL_RESPONSE).get(0);
bundle.assertContentEquals(new byte[0]);
bundle.assertAttributeEquals(InvokeHTTP.STATUS_CODE, "200");
bundle.assertAttributeEquals(InvokeHTTP.STATUS_MESSAGE, "OK");
bundle.assertAttributeEquals("Foo", "Bar");
bundle.assertAttributeEquals("Content-Type", "text/plain");
}

public static class EmptyGzipResponseHandler extends AbstractHandler {

@Override
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
baseRequest.setHandled(true);
response.setStatus(200);
response.setContentLength(0);
response.setContentType("text/plain");
response.setHeader("Content-Encoding", "gzip");
}

}
}