NIFI-7176 added InvokeHTTP support parametric READ.TIMEOUT and CONNEC… #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvillard31
requested changes
Mar 11, 2020
There was a problem hiding this comment.
Thanks @guvencenanguvenal for the pull request.
The EL cannot be evaluated against flow files attributes since it's happening during the processor initialisation. Instead, you need to use the VARIABLE_REGISTRY scope.
| @@ -182,6 +182,7 @@ | |||
| .name("Connection Timeout") | |||
| .description("Max wait time for connection to remote service.") | |||
| .required(true) | |||
| .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) | |||
There was a problem hiding this comment.
Suggested change
| .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) | |
| .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) |
| @@ -190,6 +191,7 @@ | |||
| .name("Read Timeout") | |||
| .description("Max wait time for response from remote service.") | |||
| .required(true) | |||
| .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) | |||
There was a problem hiding this comment.
Suggested change
| .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) | |
| .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) |
|
I use Apache Nifi for so long time but I am new on Apache Nifi source code. Thanks your edited but i want to read flowfile attribute so i close PR :) i will work on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvokeHTTP support evaluate expression for timeout parameters. NIFI-7126