Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7246 - External load balancer support for JWT using static, configured key #4135

Closed
wants to merge 20 commits into from

Conversation

Shreyaskc
Copy link

@Shreyaskc Shreyaskc commented Mar 11, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@joewitt
Copy link
Contributor

joewitt commented Mar 11, 2020

there appears to be several conflicts to resolve. there also needs to be a JIRA that this links to

@Shreyaskc
Copy link
Author

there appears to be several conflicts to resolve. there also needs to be a JIRA that this links to

Added a JIRA : https://issues.apache.org/jira/browse/NIFI-7246 and resolved conflicts. I have deployed this fix in my organization and its working fine.

@pvillard31 pvillard31 changed the title External load balancer support for JWT using static, configured key NIFI-7246 - External load balancer support for JWT using static, configured key Mar 11, 2020
@joewitt
Copy link
Contributor

joewitt commented Mar 13, 2020

It is super cool that you're trying to contribute. But, there does need to be discussion on something like this and so far the discussion is not favorable. I encourage you to spend more time attempting to build consensus on this change.

@Shreyaskc
Copy link
Author

I am using NiFi in my org and facing this problem, hence had to put this fix. I see that in community there are many folks facing the same problem.
Ex : https://community.cloudera.com/t5/Support-Questions/Use-REST-API-to-access-a-secured-NiFi-cluster/m-p/197818/highlight/true#M159869

@pvillard31
Copy link
Contributor

pvillard31 commented Mar 15, 2020

Why not use sticky session on the load balancer?
edit - let's continue the discussion on the JIRA where there are more details.

@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Apr 25, 2021
@github-actions github-actions bot closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants