-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-7497 Adding support for AWS Credentials Assume Role to be able t… #4309
Conversation
…o set the STS Endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @neptunesalt.
LGTM, I'm a +1. I left a comment regarding the description of this new property.
.required(false) | ||
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR) | ||
.sensitive(false) | ||
.description("STS Endpoint override for cross-account access, if needed within your environment.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the same comment as in the AWS SDK? Something like:
The default AWS Security Token Service (STS) endpoint ("sts.amazonaws.com") works for all accounts that are not for China (Beijing) region or GovCloud. You only need to set this property to "sts.cn-north-1.amazonaws.com.cn" when you are requesting session credentials for services in China(Beijing) region or to "sts.us-gov-west-1.amazonaws.com" for GovCloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvillard31 If that change is the only thing blocking this, I can make it and merge. Let me know if you're +1 on that. We have a use case that really needs this.
We tested this and confirmed it works. Merging. Thanks for the contribution! |
…o set the STS Endpoint NIFI-7497 Updating property description per comment This closes apache#4309 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
…o set the STS Endpoint NIFI-7497 Updating property description per comment This closes apache#4309 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
…o set the STS Endpoint NIFI-7497 Updating property description per comment This closes apache#4309 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
…o set the STS Endpoint NIFI-7497 Updating property description per comment This closes apache#4309 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
…o set the STS Endpoint
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables AWS Credentials to configure Assume Role STS Endpoint functionality; fixes bug NIFI-7497.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.