New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-7730 Resolved issue with keystores containing multiple certificates #4498
Conversation
I also verified that creating a |
Code looks good and tested starting the app with the multiple certs keystore and worked correctly. Running a build with Java 8 shows a test error which also seems present in the GitHub Actions build:
|
…le certificates is used
…ores. Cleaned up JettyServer code. Changed test logging severity to include debug statements. Added test resources.
.../nifi-web/nifi-jetty/src/test/groovy/org/apache/nifi/web/server/JettyServerGroovyTest.groovy
Show resolved
Hide resolved
…NS entries to resolve Java 8 test failures.
Fixed the test failure due to custom DNS entries. Thanks for catching it @bbende . Should be ready for final review once the GHA pass. |
FYI, got this tested on a previously failing deployment pipeline and it works. |
Thanks Joey. Taking that and Bryan's review as +1 and merging. |
Cleaned up JettyServer code. Changed test logging severity to include debug statements. Added test resources. This closes #4498. Co-authored-by: Kotaro Terada <kotarot@apache.org>
Cleaned up JettyServer code. Changed test logging severity to include debug statements. Added test resources. This closes apache#4498. Co-authored-by: Kotaro Terada <kotarot@apache.org>
Cleaned up JettyServer code. Changed test logging severity to include debug statements. Added test resources. This closes apache#4498. Co-authored-by: Kotaro Terada <kotarot@apache.org>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Due to a Jetty upgrade prior to the 1.12.0 release, keystores which contained multiple certificates block the application startup. This PR includes @kotarot 's submission in PR 4471 and also adds regression test cases.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.