Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7557: uses a canonical representation of strings when recovering… #4507

Closed
wants to merge 2 commits into from

Conversation

markap14
Copy link
Contributor

@markap14 markap14 commented Sep 2, 2020

… data from FlowFile Repository in order to avoid using huge amounts of heap when not necessary

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

… data from FlowFile Repository in order to avoid using huge amounts of heap when not necessary
@alopresto
Copy link
Contributor

@markap14 Looks like there are checkstyle errors for unused imports in FlowController.

@bbende
Copy link
Contributor

bbende commented Sep 3, 2020

Tested this and looks good, I resolved the checkstyle issue locally, will merge shortly

@asfgit asfgit closed this in fd068fe Sep 3, 2020
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
… data from FlowFile Repository in order to avoid using huge amounts of heap when not necessary

- Fixed some problems with unit/integration tests

This closes apache#4507.

Signed-off-by: Bryan Bende <bbende@apache.org>
adenes pushed a commit to adenes/nifi that referenced this pull request Jul 5, 2021
… data from FlowFile Repository in order to avoid using huge amounts of heap when not necessary

- Fixed some problems with unit/integration tests

This closes apache#4507.

Signed-off-by: Bryan Bende <bbende@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
… data from FlowFile Repository in order to avoid using huge amounts of heap when not necessary

- Fixed some problems with unit/integration tests

This closes apache#4507.

Signed-off-by: Bryan Bende <bbende@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants