NIFI-6920 Add empty string key check for HTTP response headers before… #4517
Conversation
… adding as attributes
| @@ -1276,7 +1276,7 @@ private String csv(Collection<String> values) { | |||
| // create a new hashmap to store the values from the connection | |||
| Map<String, String> map = new HashMap<>(); | |||
| responseHttp.headers().names().forEach((key) -> { | |||
There was a problem hiding this comment.
You would want to use StringUtils.isBlank() see other parts of the code.
There was a problem hiding this comment.
I had used the logic in org.apache.nifi.flowfile.FlowFile.KeyValidator.isValid(String) as a guideline, but I agree that this is a more appropriate solution.
|
This is pretty straight forward, +1 from me. You need a committer +1 to go with it |
|
Also, thank you for the contribution! |
|
@agreenburg Thanks for your contribution! Understanding that this is a straightforward change, can you create a unit test method for InvokeHTTP to ensure that your solution filters out blank response header keys? The |
|
@agreenburg Updates to |
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
… adding as attributes
Description of PR
Fixes bug NIFI-6920