NIFI-7802 Remove commons-configuration2 dependency from nifi-security… #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-utils which ends up nifi-standard-services-api and on the classpath of any standard services
|
Reviewing |
|
Tested with a PropertiesFileLookupService and an XMLFileLookupService, looks good. Contrib check + tests all passed. +1 |
asfgit
pushed a commit
that referenced
this pull request
Sep 17, 2020
…-utils which ends up nifi-standard-services-api and on the classpath of any standard services Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes #4525
driesva
pushed a commit
to driesva/nifi
that referenced
this pull request
Mar 19, 2021
…-utils which ends up nifi-standard-services-api and on the classpath of any standard services Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#4525
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…-utils which ends up nifi-standard-services-api and on the classpath of any standard services Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#4525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-utils which ends up
nifi-standard-services-apiand on the classpath of any standard servicesThe dependency on commons-configuration2 was added to
nifi-security-utilsas part of this ticket:https://issues.apache.org/jira/browse/NIFI-6301
The only class the uses the dependency is
SafeXMLConfiguration, so I created a new modulenifi-security-xml-configand moved this class and the dependency there, so that it doesn't get pulled into everywhere that security utils is being used.I considered making the module be just
nifi-security-xml-utilsand moving the other XML classes as well, but then there may also be another case where you want to use those classes without using commons-configuration2.In the future we should further separate
nifi-security-utils.