Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIFI-7882] Handle JsonProperties as avro field default #4575

Closed
wants to merge 3 commits into from

Conversation

alien11689
Copy link

Fixes NIFI-7882

@MikeThomsen
Copy link
Contributor

Avro 1.10.0 is using Jackson 2 now, so it would be worthwhile to check a new Avro build to see if the behavior is the same.

@alien11689
Copy link
Author

Bumping Avro to 1.9 or 1.10 is one of the available solutions, but it definitely should bump nifi minor version (1.12 -> 1.13). And of course it should be done.

But for fixing the problem as soon as possible this change is good enough. Nifi version could be bumped only with patch version and versions 1.11.5 and 1.12.2 could be released.

@mattyb149
Copy link
Contributor

Code LGTM but the test input/output files appear to have Windows-style line endings. Could you ensure the changed lines and new files have Unix-style line endings? Should be ready to merge after that.

@alien11689
Copy link
Author

Hi, I set Unix-style file endings for new files.

@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Apr 15, 2021
@github-actions github-actions bot closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants