Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7584-rebase-squash Added a POST request to the OIDC revoke endpo… #4582

Closed

Conversation

mtien-apache
Copy link
Contributor

…int for logout.

Added method to validate the OIDC Access Token for the revoke endpoint.
Created a new callback URI of oidc/logoutCallback to handle certain OIDC logout cases.
Changed method to exchange the Authorization Code for a Login Authentication Token.
Added a new method to exchange the AuthN Code for an Access Token.
Changed method to convert OIDC Token to a Login AuthN Token instead of a NiFi JWT.

NIFI-7584-rebase-squash Changed the validateAccessToken method to take an AccessTokenHash object as a parameter.

NIFI-7584-rebase-squash Changed static messages to be constant variables in AccessResource.

NIFI-7584-rebase-squash Added a check to determine which OIDC logout method to use
based on the configured OIDC discovery url in nifi.properties.

NIFI-7584-rebase-squash Separated the logout endpoints for different ID Providers.
Added a new method to exchange an AuthN Code for an ID Token.
Separated the authorization and authentication for OIDC client requests.

NIFI-7584-rebase-squash Cleaned up the code.

NIFI-7584-rebase-squash Added tests to StandardOidcProviderGroovyTest.
Extracted the Access Token validation method.

NIFI-7584-rebase-squash Created new OidcServiceGroovyTest class.

NIFI-7584-rebase-squash Fixed and added tests.

NIFI-7584-rebase-squash Added tests.

NIFI-7584-rebase-squash Cleaned up code and removed comments.

NIFI-7584-rebase-squash Fixed issue of a HTTP request not closing the connection.

NIFI-7584-rebase-squash Added Exceptions to methods.

NIFI-7584-rebase-squash [WIP] Added tests in OidcServiceTest.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

…int for logout.

Added method to validate the OIDC Access Token for the revoke endpoint.
Created a new callback URI of oidc/logoutCallback to handle certain OIDC logout cases.
Changed method to exchange the Authorization Code for a Login Authentication Token.
Added a new method to exchange the AuthN Code for an Access Token.
Changed method to convert OIDC Token to a Login AuthN Token instead of a NiFi JWT.

NIFI-7584-rebase-squash Changed the validateAccessToken method to take an AccessTokenHash object as a parameter.

NIFI-7584-rebase-squash Changed static messages to be constant variables in AccessResource.

NIFI-7584-rebase-squash Added a check to determine which OIDC logout method to use
based on the configured OIDC discovery url in nifi.properties.

NIFI-7584-rebase-squash Separated the logout endpoints for different ID Providers.
Added a new method to exchange an AuthN Code for an ID Token.
Separated the authorization and authentication for OIDC client requests.

NIFI-7584-rebase-squash Cleaned up the code.

NIFI-7584-rebase-squash Added tests to StandardOidcProviderGroovyTest.
Extracted the Access Token validation method.

NIFI-7584-rebase-squash Created new OidcServiceGroovyTest class.

NIFI-7584-rebase-squash Fixed and added tests.

NIFI-7584-rebase-squash Added tests.

NIFI-7584-rebase-squash Cleaned up code and removed comments.

NIFI-7584-rebase-squash Fixed issue of a HTTP request not closing the connection.

NIFI-7584-rebase-squash Added Exceptions to methods.

NIFI-7584-rebase-squash [WIP] Added tests in OidcServiceTest.
@mtien-apache
Copy link
Contributor Author

Still need to add one more unit test, but the rest of the changes may be reviewed in the mean time. Thanks. @alopresto @thenatog @bbende @mcgilman

@mtien-apache mtien-apache marked this pull request as ready for review October 8, 2020 22:18
@mtien-apache
Copy link
Contributor Author

Opened a new PR #4593. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant