NIFI-7584-rebase-squash Added a POST request to the OIDC revoke endpo… #4582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…int for logout.
Added method to validate the OIDC Access Token for the revoke endpoint.
Created a new callback URI of oidc/logoutCallback to handle certain OIDC logout cases.
Changed method to exchange the Authorization Code for a Login Authentication Token.
Added a new method to exchange the AuthN Code for an Access Token.
Changed method to convert OIDC Token to a Login AuthN Token instead of a NiFi JWT.
NIFI-7584-rebase-squash Changed the validateAccessToken method to take an AccessTokenHash object as a parameter.
NIFI-7584-rebase-squash Changed static messages to be constant variables in AccessResource.
NIFI-7584-rebase-squash Added a check to determine which OIDC logout method to use
based on the configured OIDC discovery url in nifi.properties.
NIFI-7584-rebase-squash Separated the logout endpoints for different ID Providers.
Added a new method to exchange an AuthN Code for an ID Token.
Separated the authorization and authentication for OIDC client requests.
NIFI-7584-rebase-squash Cleaned up the code.
NIFI-7584-rebase-squash Added tests to StandardOidcProviderGroovyTest.
Extracted the Access Token validation method.
NIFI-7584-rebase-squash Created new OidcServiceGroovyTest class.
NIFI-7584-rebase-squash Fixed and added tests.
NIFI-7584-rebase-squash Added tests.
NIFI-7584-rebase-squash Cleaned up code and removed comments.
NIFI-7584-rebase-squash Fixed issue of a HTTP request not closing the connection.
NIFI-7584-rebase-squash Added Exceptions to methods.
NIFI-7584-rebase-squash [WIP] Added tests in OidcServiceTest.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.