NIFI-1908 Added encoding-version attribute to TemplateDTO #471
Conversation
|
Reviewing... |
added scaling of templates upon instantiation for placement on the canvas added template-0.7.0.xml for live-testing the import of templates
| .map(remoteGroup -> remoteGroup.getId()) | ||
| .forEach(id -> identifiers.add(id)); | ||
| snippet.getRemoteProcessGroups().stream() | ||
| .flatMap(remoteGroup -> remoteGroup.getContents().getInputPorts().stream()) |
There was a problem hiding this comment.
@jtstorck I thought that you had fixed a separate bug here when the RemoteGroupPort's are null and not yet initialized? Was this the result of something else?
There was a problem hiding this comment.
I did fix that bug, in the createTemplateInstance method. Looks like copySnippet might have the same issue.
There was a problem hiding this comment.
Ah sorry. Looks like your right.
There was a problem hiding this comment.
I went ahead and addressed the issue myself. Take a look and make sure we're on the same page.
|
Other changes look good! Will merge to master. During my testing of a 1.x template in an 0.x instance I discovered a separate issue that the templates from an 1.x instance are currently not including the child group contents. I've created a new JIRA to address this issue [1]. Testing with a sub-group-less 1.x template worked fine in a 0.x instance. |
added scaling of templates upon instantiation for placement on the canvas added template-0.7.0.xml for live-testing the import of templates Fixing issue with potentially uninitialized RemoteGroupPorts in copySnippet. This closes apache#471
added scaling of templates upon instantiation for placement on the canvas
added template-0.7.0.xml for live-testing the import of templates