Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-8062: make tabs functional with keyboard #4724

Merged
merged 1 commit into from Jan 4, 2021

Conversation

sardell
Copy link
Contributor

@sardell sardell commented Dec 11, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

This PR adds keyboard functionality to the custom tabbs jquery plugin.

Testing

Build NiFi locally, open the UI and locate anywhere that uses tabs (for example, inside the Global Menu's Summary window). Click on a tab. Navigate to the next tab by pressing the Tab key. Navigate back to the previous tab with Shift + Tab. Select a tab by focusing on it and pressing Enter or Space. You'll notice focus styles have been added.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@markap14
Copy link
Contributor

markap14 commented Jan 4, 2021

Verified that I'm able to switch between tabs in the processor config dialog and in the Controller Settings dialog. Based on the code changes, I think this should apply to all dialogs. Of note, in order to verify that, I had to click on one of the text boxes / inputs within the form and then press shift-tab to get to the tabs. Otherwise, just pressing tab jumped all over the place, as it selected elements in the background (like the search box) even though there was a dialog open. We should probably only allow tab to jump to elements in the dialog when a dialog is present. That said, I don't think it needs to be done in this PR/Jira. So I'm a +1. Will merge to main. Thanks @sardell !

@markap14 markap14 merged commit 5c79553 into apache:main Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants