Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-8177 Added timeout to Sender Pool polling to avoid blocking #4786

Closed
wants to merge 1 commit into from

Conversation

exceptionfactory
Copy link
Contributor

Description of PR

NIFI-8177 Adds pollSenderPool() to AbstractPutEventProcessor to avoid blocking indefinitely in pruneIdleSenders() and other methods. The pollSenderPool() returns null immediately if the sender pool is empty, following the existing behavior of LinkedBlockingQueue.poll(). Introducing a timeout of 250 ms avoids the potential for timeouts during unit tests on some systems.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@joewitt
Copy link
Contributor

joewitt commented Jan 27, 2021

build worked great locally on a fast box with 11.0.10. 13 mins total build time now!!! will see how github likes it and if we're green then on to 1.13

@asfgit asfgit closed this in 8c1fe84 Jan 27, 2021
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
…ng to avoid blocking indefinitely

Signed-off-by: Joe Witt <joewitt@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…ng to avoid blocking indefinitely

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants