NIFI-8300 Make non-source processors invalid if scheduled for Primary… #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markap14
requested changes
Mar 18, 2021
Comment on lines
1095
to
1097
| if (getExecutionNode() == ExecutionNode.PRIMARY) { | ||
| if (getInputRequirement() == Requirement.INPUT_REQUIRED | ||
| || getInputRequirement() == Requirement.INPUT_ALLOWED && !getIncomingConnections().isEmpty()) { |
There was a problem hiding this comment.
I think this can be simplified to just: if (getExecutionNode() == ExecutionNode.PRIMARY && hasIncomingConnection()) {
| if (getInputRequirement() == Requirement.INPUT_REQUIRED | ||
| || getInputRequirement() == Requirement.INPUT_ALLOWED && !getIncomingConnections().isEmpty()) { | ||
| results.add(new ValidationResult.Builder() | ||
| .explanation("Processor should set to run on all nodes.") |
There was a problem hiding this comment.
Probably need to provide more details in the explanation. Why should the processor be set to run on all nodes? Perhaps something to the effect of "Processors with incoming connections cannot be scheduled for Primary Node Only."
|
Thanks for your review @markap14 , it looks better now |
|
Thanks @s9514171 ! Looks good to me too. +1 merged to main! |
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
… Node only This closes apache#4913. Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Node only
Description of PR
Set the processor state to invalid, when the processor has upstream connection and set to "Primary node only"
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.