New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-8501: Setup Azure blob client side encryption #5078
Conversation
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gschaer Thanks for the work on this. I went through and tested all the functionality. In addition to the code comments I have a few other things:
- Right now if the encryption type is NONE and a key id and key are specified the configuration is valid. It doesn't encrypt the files as expected, but I think this is confusing. I'd say it's more typical to mark cases like that as invalid.
- The
azure.length
property reflects the encrypted object length and not the decrypted length. I've seen similar situations cause problems. This makes me think it could be useful to add an attribute that specified whether it was encrypted so there's some indicator that some of the metadata might not match. - I think it might be useful to add something to an additionalDetails.html file to explain more about the behavior or how to create the keys.
.../java/org/apache/nifi/processors/azure/storage/utils/AzureBlobClientSideEncryptionUtils.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/nifi/processors/azure/storage/utils/AzureBlobClientSideEncryptionUtils.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/nifi/processors/azure/storage/utils/AzureBlobClientSideEncryptionUtils.java
Show resolved
Hide resolved
...rocessors/src/test/java/org/apache/nifi/processors/azure/storage/ITListAzureBlobStorage.java
Outdated
Show resolved
Hide resolved
...rocessors/src/test/java/org/apache/nifi/processors/azure/storage/ITListAzureBlobStorage.java
Outdated
Show resolved
Hide resolved
...processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureBlobStorage.java
Outdated
Show resolved
Hide resolved
...processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureBlobStorage.java
Outdated
Show resolved
Hide resolved
...processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureBlobStorage.java
Outdated
Show resolved
Hide resolved
|
||
import static org.junit.Assert.fail; | ||
|
||
public class ITAzureBlobStorageE2E { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should any of this be moved to the AbstractAzureBlobStorageIT
? (In which case, already existing tests would need to be updated too.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tricky one... It would require complex rewrite of all these tests.
.../java/org/apache/nifi/processors/azure/storage/utils/AzureBlobClientSideEncryptionUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gschaer Thanks for the changes. I tested the put and fetch with and without CSE, ran the ITs, and tested an upgrade. LGTM. Will merge shortly.
This closes apache#5078 Signed-off-by: Joey Frazee <jfrazee@apache.org>
This closes apache#5078 Signed-off-by: Joey Frazee <jfrazee@apache.org>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds Azure blob client side encryption (symmetric only). Fixes NIFI-8501.
Also fixes NIFI-8508 by incrementing the amount of time the thread is sleeping when doing the integration testing.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.