New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-4344: Improve bulletin messages with exception details. #5093
Conversation
...work/nifi-framework-core/src/main/java/org/apache/nifi/controller/tasks/ConnectableTask.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @Lehel44. I noted a couple detailed comments, but after reading the Jira issue, it seems like this may require additional work. Formatting changes seem necessary for presentation in the browser, which may require changing the bulletin model.
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
...ework-components/src/main/java/org/apache/nifi/logging/repository/StandardLogRepository.java
Outdated
Show resolved
Hide resolved
Based on @tpalfy comment I have changed the place of formatting messages to SimpleProcessLogger in order to avoid branching in LoggingRepository. (The exception messages differs based on they are created by the framework or logged directly.) |
74b9907
to
b75ee5b
Compare
...k/nifi-framework-components/src/main/java/org/apache/nifi/processor/SimpleProcessLogger.java
Show resolved
Hide resolved
...fi-framework-components/src/test/java/org/apache/nifi/processor/TestSimpleProcessLogger.java
Outdated
Show resolved
Hide resolved
9875da9
to
1e17684
Compare
...k/nifi-framework-components/src/main/java/org/apache/nifi/processor/SimpleProcessLogger.java
Outdated
Show resolved
Hide resolved
...fi-framework-components/src/test/java/org/apache/nifi/processor/TestSimpleProcessLogger.java
Outdated
Show resolved
Hide resolved
...k/nifi-framework-components/src/main/java/org/apache/nifi/processor/SimpleProcessLogger.java
Outdated
Show resolved
Hide resolved
...fi-framework-components/src/test/java/org/apache/nifi/processor/TestSimpleProcessLogger.java
Outdated
Show resolved
Hide resolved
LGTM+1 |
This closes apache#5093. Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
This closes apache#5093. Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
This closes apache#5093. Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
the beginning of the log message, don't need to add it manually.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.