Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4344: Improve bulletin messages with exception details. #5093

Closed
wants to merge 4 commits into from

Conversation

Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented May 21, 2021

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

  • Changed exception message in Connectable task. Component log automatically adds the component name and id to
    the beginning of the log message, don't need to add it manually.
  • Added functionality to make chained exceptions displayed nicely in bulletins.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @Lehel44. I noted a couple detailed comments, but after reading the Jira issue, it seems like this may require additional work. Formatting changes seem necessary for presentation in the browser, which may require changing the bulletin model.

@Lehel44
Copy link
Contributor Author

Lehel44 commented May 25, 2021

Based on @tpalfy comment I have changed the place of formatting messages to SimpleProcessLogger in order to avoid branching in LoggingRepository. (The exception messages differs based on they are created by the framework or logged directly.)

@Lehel44 Lehel44 force-pushed the NIFI-4344 branch 3 times, most recently from 74b9907 to b75ee5b Compare May 26, 2021 07:48
@Lehel44 Lehel44 force-pushed the NIFI-4344 branch 6 times, most recently from 9875da9 to 1e17684 Compare June 1, 2021 08:50
@asfgit asfgit closed this in 0c748a5 Jun 23, 2021
@tpalfy
Copy link
Contributor

tpalfy commented Jun 23, 2021

LGTM+1
Merged into main.

timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 6, 2021
This closes apache#5093.

Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 21, 2021
This closes apache#5093.

Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5093.

Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants