NIFI-1850 - JSON-to-JSON Schema Converter Editor #511
Conversation
YolandaMDavis
force-pushed
the
NIFI-1850-master
branch
from
8d6b9a4
to
5f1445d
Compare
| .validateErrors(processor.getValidationErrors()).build(); | ||
| } | ||
|
|
||
| private Map<String,ComponentDescriptor> getComponentDescriptors(final ProcessorConfigDTO processorConfig){ |
There was a problem hiding this comment.
Do you think it would be more appropriate to name the operation buildComponentDescriptors(..) instead of get*?
IMHO get* usually implies an operation that is returning something that already exist. Your call, but wanted to share.
There was a problem hiding this comment.
@olegz makes sense to me I can change this
|
@YolandaMDavis While I believe it looks good, I think someone from the web team has to look at it as well |
YolandaMDavis
force-pushed
the
NIFI-1850-master
branch
from
5f1445d
to
1dfb813
Compare
|
@olegz thanks for taking a look! as noted above I'll make the changes cited and update this request. |
YolandaMDavis
force-pushed
the
NIFI-1850-master
branch
from
1dfb813
to
88f32f3
Compare
| @@ -355,10 +355,5 @@ | |||
| <artifactId>spock-core</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Was this dependency no longer used or does this PR make it unnecessary now?
There was a problem hiding this comment.
hmm I didn't directly remove this perhaps odd merge during rebase? Spock tests are still functioning however I will restore it just in case.
|
@YolandaMDavis While reading over your PR I noticed that the ControllerService and ReportingTask URI's in the StandandNiFiWebConfigurationContext are incorrect. They shouldn't contain the path segment |
YolandaMDavis
force-pushed
the
NIFI-1850-master
branch
from
88f32f3
to
ca1335d
Compare
|
@mcgilman Thank you for reviewing! The PR has been updated based on your comments, including the corrections in the path segment for StandardNiFiWebConfigurationContext. I also found that same path in ComponentStateEndointMerger as part of a regex pattern which I corrected as well. |
…merge from 0.7.0 - refactor for masterless cluster)
YolandaMDavis
force-pushed
the
NIFI-1850-master
branch
from
ca1335d
to
95e9fd2
Compare
|
Looks great @YolandaMDavis I'm merged this into master. Thanks! |
This is a merge from 0.7 of the Json-to-Json (Jolt) Editor with refactoring for masterless clustering and bower dependency support.