NIFI-1952 Create REST endpoints for user/group/policy management #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing... |
| final Authorizable accessPolicy = lookup.getAccessPolicyAuthorizable(id); | ||
| accessPolicy.authorize(authorizer, RequestAction.READ); | ||
| }, | ||
| () -> {}, |
There was a problem hiding this comment.
Can pass in null for the verifier.
There was a problem hiding this comment.
Okay, will update with null.
|
@jtstorck Lets knock out these couple trivial items. Looks good so far. |
jtstorck
force-pushed
the
NIFI-1952
branch
2 times, most recently
from
9daa68e
to
7dbdbc6
Compare
|
@mcgilman I've addressed most of your comments on the PR aside from renaming Group to UserGroup, which I still plan on doing soon. Please take a look at my latest commit on the PR. |
created REST Resources for users, groups, and access policies added Authorizables for users, groups, and access policies added methods to DtoFactory and EntityFactory to create objects for users, groups, and access policies extracted anonymous AuthorizableLookup impl in StandardNiFiServiceFacade.java to a protected class to make the lookup call mockable in tests added methods to manage users/groups/access policies to StandardNiFiServiceFacade added StandardNiFiServiceFacadeSpec to unit-test management of users/groups/access policies added implementations for UserDAO, GroupDAO, AccessPolicyDAO. added spring config for user/group/policy resources and daos
…onger requires the use of the revision manager updated StandardNiFiServiceFacadeSpec based on user/group/policy creation changes condensed user/group/policy DAOs to a single DAO (StandardPolicyBasedAuthorizerDAO) fixed spring config of user/group/policy REST resources
…heir IDs mid-progress on updating tests
…ts for users, groups, policies
|
Looks great @jtstorck! I've merged this into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created REST Resources for users, groups, and access policies
added Authorizables for users, groups, and access policies
added methods to DtoFactory and EntityFactory to create objects for users, groups, and access policies
extracted anonymous AuthorizableLookup impl in StandardNiFiServiceFacade.java to a protected class to make the lookup call mockable in tests
added methods to manage users/groups/access policies to StandardNiFiServiceFacade
added StandardNiFiServiceFacadeSpec to unit-test management of users/groups/access policies
added implementations for UserDAO, GroupDAO, AccessPolicyDAO.
added spring config for user/group/policy resources and daos