NIFI-9252 Removed unused nifi.sensitive.props.provider Property

[exceptionfactory]

Description of PR

NIFI-9252 Removes the unused nifi.sensitive.props.provider property from NiFiProperties and also removes the related nifi.minifi.sensitive.props.provider property from MiNiFi. This property is no longer used following the refactoring of component property encryption for NIFI-7668 in #4809.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically main)?

• Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• Have you verified that the full build is successful on JDK 8?
• Have you verified that the full build is successful on JDK 11?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

[gresockj]

Thanks for cleaning up this unused property, @exceptionfactory. NiFi started up successfully without the property for me. +1 for me

[markobean]

Searched code for any remaining references to nifi.sensitive.props.provider. Found none. Any similar term searches show that the property is using hardcoded value "BC" where applicable (e.g. SensitivePropsSchema in minifi.)
Also, built and started NiFi with this patch. No issues.
+1

[mattyb149]

For consistency we should probably remove all (albeit harmless) references to the provider, in places like SensitivePropsSchema, RunMiNiFiTest, etc.

[exceptionfactory]

For consistency we should probably remove all (albeit harmless) references to the provider, in places like SensitivePropsSchema, RunMiNiFiTest, etc.

Thanks for the feedback @mattyb149, that makes sense. I pushed an update removing the property from SensitivePropsSchema and RunMiNiFiTest.

[exceptionfactory]

Rebased from main and squashed commits to resolve conflict with Stateless Dataflow Configuration class.

[gresockj]

Based on my runtime verification and the input from others, I'll go ahead and merge this. Thanks, @exceptionfactory!