Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-9351 Exclude test dependencies from nifi-scripting-nar #5498

Closed
wants to merge 2 commits into from

Conversation

exceptionfactory
Copy link
Contributor

@exceptionfactory exceptionfactory commented Oct 29, 2021

Description of PR

NIFI-9351 Excludes JUnit and TestNG dependencies from the groovy-all dependency declaration in nifi-scripting-nar and nifi-groovyx-nar. This change avoids including unnecessary test dependencies during runtime processing.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Updated nifi-scripting-nar
- Updated nifi-groovyx-nar
@mattyb149 mattyb149 added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 29, 2021
@mattyb149
Copy link
Contributor

+1 LGTM, ran mvn clean install -Pcontrib-check then dependency:tree on both bundles, verified there are no test dependencies other than in test scope. Thanks for the fix and the quick turnaround! Merging to main

@mattyb149 mattyb149 closed this in 1c4ee93 Oct 29, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
NIFI-9351 Excluded Groovy test dependencies

- Updated nifi-scripting-nar
- Updated nifi-groovyx-nar

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#5498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
2 participants