NIFI-2059: Ensure that we properly pass along proxied entities in HTT… #572
+34
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If the user is authenticated, add them as a proxied entity so that when the receiving NiFi receives the request, | ||
| // it knows that we are acting as a proxy on behalf of the current user. | ||
| final NiFiUser user = NiFiUserUtils.getNiFiUser(); | ||
| if (user != null && !user.equals(NiFiUser.ANONYMOUS)) { |
There was a problem hiding this comment.
Should use user.isAnonymous() to detect anonymous user.
|
Reviewing... |
…P headers when secure and ensure that we don't keep creating new Root Group ID's once we've created one, even after restart
|
@mcgilman the PR has been updated to incorporate the feedback you provided. Thanks! |
|
Looks great @markap14! This has been merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…P headers when secure and ensure that we don't keep creating new Root Group ID's once we've created one, even after restart