Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-9233 - Improve reliability of system integration tests #5733

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

greyp9
Copy link
Contributor

@greyp9 greyp9 commented Feb 1, 2022

Description of PR

Avoid deadlock on process shutdown during system test invocation. This SaveReportingTask lock usage contends with lock in StandardFlowService.stop() (which releases after gracefulShutdownSeconds).

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@greyp9 greyp9 marked this pull request as draft February 1, 2022 19:40
@greyp9 greyp9 marked this pull request as ready for review February 1, 2022 22:29
@markap14 markap14 merged commit 9dbd066 into apache:main Feb 3, 2022
@markap14
Copy link
Contributor

markap14 commented Feb 3, 2022

Thanks for the update @greyp9. This makes sense, avoids an issue in the system tests where we update the flow and immediately shutdown before changes are saved. +1 merged to main.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants