[NIFI-2027] Responsive Tables #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing... |
|
@scottyaslan Looks like this PR addresses the size issues we were seeing with the exception of the queue listing table and the comopnent state table. The only additional comment I have is around the use of Javascript to re-calculate the table height. Where possible we should allow CSS to do this to avoid the extra cycles keep it simple. I'll wait for an update that includes the few extra tables before I merge. Thanks! |
| if (top === window) { | ||
| provenanceTableHeight -= 80; //80 for padding | ||
| } | ||
| $('#provenance-table').height(provenanceTableHeight).show(); |
There was a problem hiding this comment.
I think this logic is unnecessary as the provenance table is bound from the bottom using position absolute. The height should adjust due to the CSS rules.
scottyaslan
force-pushed
the
responsiveDevBranch
branch
from
7fcf5ee
to
608464b
Compare
scottyaslan
force-pushed
the
responsiveDevBranch
branch
from
608464b
to
ef85caf
Compare
|
Thanks @scottyaslan! This has been merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Processor config properties tables
-Summary Tables
-Counters Table
-History Table
-Data Provenance Table
-Template Table
-Process Group Config, Controller Services table
-Settings Controller Services Table
-Settings Reporting Tasks Table
-New Processor Types Table
-Controller Services Types Table
-Reporting Tasks Types Table
-Queue Listing Table
-Component State Table
-Flow File Details dialog
-listing request status dialog