New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-9590 - Updated encrypt-config to allow encrypt/decrypt of sensitive value in Azure authorizers #5833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the toolkit @thenatog! The runtime changes look good, but it looks like the tests could be streamlined. Understanding that the current test methods include a lot of logging, it would be helpful to remove logging from these new unit test methods. It also seems helpful to remove commented sections of example files as much as possible.
...it-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy
Outdated
Show resolved
Hide resolved
...it-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy
Outdated
Show resolved
Hide resolved
nifi-toolkit/nifi-toolkit-encrypt-config/src/test/resources/authorizers-populated-azure.xml
Outdated
Show resolved
Hide resolved
…ommented lines from test file.
import org.apache.nifi.org.h2.jdbcx.JdbcDataSource; | ||
import org.h2.jdbcx.JdbcDataSource; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most recent GitHub builds failed due to this migrator change, which should be reverted so that it continues to reference the shaded class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, reverted. Got this working in my IDE now, but obviously did this as a quick workaround for the H2 compile issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @thenatog, this looks good! +1 merging.
… to encrypt-config This closes apache#5833 Signed-off-by: David Handermann <exceptionfactory@apache.org>
… to encrypt-config This closes apache#5833 Signed-off-by: David Handermann <exceptionfactory@apache.org>
… config encrypt tool.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.