Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-9590 - Updated encrypt-config to allow encrypt/decrypt of sensitive value in Azure authorizers #5833

Closed
wants to merge 6 commits into from

Conversation

thenatog
Copy link
Contributor

@thenatog thenatog commented Mar 3, 2022

… config encrypt tool.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@thenatog thenatog changed the title Nifi 9590 rebased NIFI-9590 - Updated encrypt-config to allow encrypt/decrypt of sensitive value in Azure authorizers Mar 3, 2022
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the toolkit @thenatog! The runtime changes look good, but it looks like the tests could be streamlined. Understanding that the current test methods include a lot of logging, it would be helpful to remove logging from these new unit test methods. It also seems helpful to remove commented sections of example files as much as possible.

import org.apache.nifi.org.h2.jdbcx.JdbcDataSource;
import org.h2.jdbcx.JdbcDataSource;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent GitHub builds failed due to this migrator change, which should be reverted so that it continues to reference the shaded class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, reverted. Got this working in my IDE now, but obviously did this as a quick workaround for the H2 compile issue :)

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @thenatog, this looks good! +1 merging.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
… to encrypt-config

This closes apache#5833

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
… to encrypt-config

This closes apache#5833

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants