Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2150: Cleanse more values from templates that are not necessary.… #593

Closed
wants to merge 2 commits into from

Conversation

markap14
Copy link
Contributor

… Additionally, updated javadocs in ProcessorConfigDTO to provide further explanation of the getAutoTerminatedRelationships() method, since this was confusing

… Additionally, updated javadocs in ProcessorConfigDTO to provide further explanation of the getAutoTerminatedRelationships() method, since this was confusing
@mcgilman
Copy link
Contributor

Reviewing...

@mcgilman
Copy link
Contributor

Just glancing through an old template and looks like we should also be scrubbing the following...

  • Process Group
    -- activeRemotePortCount, disabledCount, inactiveRemotePortCount, inputPortCount, invalidCount, outputPortCount, runningCount, stoppedCount
  • Remote Process Group
    -- activeRemoteInputPortCount, activeRemoteOutputPortCount, inactiveRemoteInputPortCount, inactiveRemoteOutputPortCount, name
  • Root Group Port
    -- transmitting, validationErrors

@markap14
Copy link
Contributor Author

@mcgilman good call! I also found a few more things for these components that we don't need. I have pushed a new commit so that you can look at it and make sure that the changes all make sense to you, as well.

@mcgilman
Copy link
Contributor

mcgilman commented Jul 1, 2016

@markap14 Looks great! I made one additional change to populate snippet results off of the actual components instead of just the snippet contents (since the contents are now pruned).

mcgilman@1b8d231

@markap14
Copy link
Contributor Author

markap14 commented Jul 1, 2016

@mcgilman good call. Looks good to me!

@asfgit asfgit closed this in 8eb0a38 Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants