NIFI-1413: Ensure that if a node's templates don't match the clusters… #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that we take the following actions: -Local templates remain but aren't shown in the cluster's templates. -Any templates from the cluster that don't exist on the node are added to the node. -Any conflicting template definitions are replaced by those in the clutser
|
+1 LGTM, built and ran with a 3-node cluster. Took one node offline, changed it's template information, then restarted and it reconnected successfully. Would be nice to have an integration test for that someday :) Merging to master, thanks! |
markap14
added a commit
to markap14/nifi
that referenced
this pull request
Jul 14, 2016
… that we take the following actions: -Local templates remain but aren't shown in the cluster's templates. -Any templates from the cluster that don't exist on the node are added to the node. -Any conflicting template definitions are replaced by those in the cluster This closes apache#596
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2016
… that we take the following actions: -Local templates remain but aren't shown in the cluster's templates. -Any templates from the cluster that don't exist on the node are added to the node. -Any conflicting template definitions are replaced by those in the cluster This closes #596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… that we take the following actions:
-Local templates remain but aren't shown in the cluster's templates.
-Any templates from the cluster that don't exist on the node are added to the node.
-Any conflicting template definitions are replaced by those in the clutser