Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-10281 - Added FetchGoogleDrive processor. #6248

Closed
wants to merge 2 commits into from

Conversation

tpalfy
Copy link
Contributor

@tpalfy tpalfy commented Jul 26, 2022

Summary

NIFI-10281

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Tamas Palfy added 2 commits July 26, 2022 20:00
…nd attribute output for ListGoogleDrive. (Record fields and flowfile attributes are now the same.)
…nd attribute output for ListGoogleDrive. (Record fields and flowfile attributes are now the same.)
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpalfy Thanks for adding this new processor! I tested it in tandem with ListGoogleDrive and also alone.

Found 2 edge cases that do not work properly:

  • Fetch can retrieve a trashed file. Though I'm not sure it could be solved efficiently in the Fetch processor. List already filters out the trash before Fetch so it is not an issue for List+Fetch.
  • Record processing was added in Fetch but the empty FlowFile is not handled properly: no outgoing FF in this case. The FF should go to input-failure in my opinion. List never creates empty FFs, so the List/Fetch combo works well here too.

As List+Fetch work properly together, I will merge this PR and create follow-up jiras to improve the Fetch processor in terms of the edge cases described above.

@asfgit asfgit closed this in 2fae3bb Jul 27, 2022
@tpalfy tpalfy deleted the NIFI-10281 branch December 6, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants