Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-10498 Added ciphersuite configuration to NiFi Registry #6458

Closed

Conversation

jeremysnyder
Copy link

@jeremysnyder jeremysnyder commented Sep 28, 2022

Summary

NIFI-10498

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@jeremysnyder jeremysnyder force-pushed the NIFI-10498-registry-cipher-suites branch from 370b625 to d48181d Compare September 29, 2022 12:51
@dorschs57
Copy link

👍 This functionality is needed for security compliance.

@exceptionfactory exceptionfactory self-assigned this Oct 8, 2022
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jeremysnyder! This follows the implementation pattern for NiFi and works as designed. This highlights an opportunity for refactoring the NiFi Registry Jetty Server to use code from nifi-jetty-configuration, but that could be considered in separate work. This looks good given the limited scope and set of changes. +1 merging

emiliosetiadarma pushed a commit to emiliosetiadarma/nifi that referenced this pull request Oct 10, 2022
This closes apache#6458

Signed-off-by: David Handermann <exceptionfactory@apache.org>
emiliosetiadarma pushed a commit to emiliosetiadarma/nifi that referenced this pull request Oct 11, 2022
This closes apache#6458

Signed-off-by: David Handermann <exceptionfactory@apache.org>
emiliosetiadarma pushed a commit to emiliosetiadarma/nifi that referenced this pull request Oct 13, 2022
This closes apache#6458

Signed-off-by: David Handermann <exceptionfactory@apache.org>
p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
This closes apache#6458

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants