NIFI-10667 Add Private Key Service interface and implementation #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Defined PrivateKeyService in nifi-key-service-api - Implemented StandardPrivateKeyService using Bouncy Castle library
|
Will review |
turcsanyip
requested changes
Oct 20, 2022
There was a problem hiding this comment.
@exceptionfactory Thanks for adding this controller service!
I tested it with both encrypted and non-encrypted private keys and it works properly.
I found an invalid configuration case which is not handled correctly.
Also added some other comments as possible improvements.
...y-service/src/main/java/org/apache/nifi/key/service/reader/BouncyCastlePrivateKeyReader.java
Outdated
Show resolved
Hide resolved
...le/nifi-key-service/src/main/java/org/apache/nifi/key/service/StandardPrivateKeyService.java
Outdated
Show resolved
Hide resolved
...le/nifi-key-service/src/main/java/org/apache/nifi/key/service/StandardPrivateKeyService.java
Show resolved
Hide resolved
turcsanyip
approved these changes
Oct 20, 2022
|
+1 looks good to me |
priyanka-28
pushed a commit
to priyanka-28/nifi
that referenced
this pull request
Nov 16, 2022
- Defined PrivateKeyService in nifi-key-service-api - Implemented StandardPrivateKeyService using Bouncy Castle library NIFI-10667 Improved custom validation to avoid repetitive reads NIFI-10667 Added onPropertyModified() to clear Key Reference for validation Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#6553.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10667 Adds a new
PrivateKeyServiceController Service interface andStandardPrivateKeyServiceimplementation capable of reading encrypted or unencrypted Private Keys.The service interface is defined in a new
nifi-key-service-apimodule undernifi-standard-services. The standard implementation uses the Bouncy Castle library andPEMParserclass to handle decoding and decrypting Private Keys. The initial implementation supports PEM encoding and PKCS 8, which can be used for several standard key algorithms including RSA and DSA.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation