Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-10751 Add Username to User and Group CRUD #6614

Merged
merged 1 commit into from
Nov 14, 2022
Merged

NIFI-10751 Add Username to User and Group CRUD #6614

merged 1 commit into from
Nov 14, 2022

Conversation

shawnweeks
Copy link
Contributor

@shawnweeks shawnweeks commented Nov 2, 2022

Summary

NIFI-10751

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@bbende
Copy link
Contributor

bbende commented Nov 14, 2022

@shawnweeks this looks good, I know its a fairly simple change, but could we update the unit test for the event factory? TestEventFactory it would help to avoid situations like this

@shawnweeks
Copy link
Contributor Author

I'll take care of that today @bbende

@shawnweeks
Copy link
Contributor Author

@bbende added test cases

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge

@bbende bbende merged commit e877497 into apache:main Nov 14, 2022
@shawnweeks shawnweeks deleted the NIFI-10751 branch November 15, 2022 13:07
lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants