Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-10767: When an empty line is encountered with Syslog Readers, ju… #6623

Closed
wants to merge 1 commit into from
Closed

NIFI-10767: When an empty line is encountered with Syslog Readers, ju… #6623

wants to merge 1 commit into from

Conversation

markap14
Copy link
Contributor

@markap14 markap14 commented Nov 4, 2022

…st skip over the empty line instead of throwing an Exception

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@markap14
NIFI-10767: When an empty line is encountered with Syslog Readers, ju…
d07b14c 
…st skip over the empty line instead of throwing an Exception
exceptionfactory
exceptionfactory approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @markap14, looks good! +1 merging

lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
@markap14 @lizhizhou
NIFI-10767: When an empty line is encountered with Syslog Readers, ju…
e0c3f99 
…st skip over the empty line instead of throwing an Exception

This closes apache#6623

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@markap14 @exceptionfactory