NIFI-10874 Fixing issue with multiple levels of versioned flows #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markap14
reviewed
Nov 28, 2022
| @@ -2013,7 +2014,13 @@ public Response createProcessGroup( | |||
| // Step 2: Retrieve flow from Flow Registry | |||
| final RegisteredFlowSnapshot flowSnapshot = getFlowFromRegistry(versionControlInfo); | |||
|
|
|||
| // Step 3: Resolve Bundle info | |||
| // Step 3: Enrich version control info came from UI | |||
| final VersionedFlowCoordinates versionedFlowCoordinates = flowSnapshot.getFlowContents().getVersionedFlowCoordinates(); // If not null.... | |||
There was a problem hiding this comment.
@simonbence did you intend to check for nulls here? Looks like possibility of NPE?
There was a problem hiding this comment.
You are correct, I forgot the comment there from development. In the line below the null check for versionedFlowCoordinates happens. My understanding is that, getFlowContents should not return null but as it is from outside NiFi, you are absolutely right, it worth to add a check for that too
exceptionfactory
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Thanks for the correction, and making the updates in response to feedback @simonbence, the latest version looks good. +1 merging
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2022
This closes #6719 Signed-off-by: David Handermann <exceptionfactory@apache.org>
lizhizhou
pushed a commit
to lizhizhou/nifi
that referenced
this pull request
Jan 2, 2023
This closes apache#6719 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10874
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation