NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17 #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added empty check for list of discovered Script Engines to avoid exceptions for documentation generation on Java 17
|
+1 LGTM, thanks for the improvement! Merging to main |
lizhizhou
pushed a commit
to lizhizhou/nifi
that referenced
this pull request
Jan 2, 2023
- Added empty check for list of discovered Script Engines to avoid exceptions for documentation generation on Java 17 Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#6774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10958 Adjusts Script Engine property handling in
ScriptingComponentsHelperto avoid exceptions on Java 17 during documentation generation. Additional work is necessary to support ECMAScript and the Nashorn engine on Java 17, but introduced an empty check during the Script Engine introspection process avoids complete documentation generation failures.Current unit tests for
createResources()work on Java 17 because the test environment has available classes.Further work on ECMAScript support using the Nashorn engine dependency on Java 17 is described in NIFI-9383.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation