Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11061: implemented NiFi Registry property for specifying network… #6931

Closed
wants to merge 4 commits into from
Closed

NIFI-11061: implemented NiFi Registry property for specifying network… #6931

wants to merge 4 commits into from

Conversation

emiliosetiadarma
Copy link
Contributor

… interface when connecting over HTTPS

Summary

NIFI-11061

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @emiliosetiadarma! The basic approach looks good and follows the pattern of the NiFi implementation. As this is a new feature for Registry, there are a couple opportunities to simplify the approach.

...istry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java Outdated Show resolved Hide resolved
...istry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java Outdated Show resolved Hide resolved
...istry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java Outdated Show resolved Hide resolved
...try-properties/src/main/java/org/apache/nifi/registry/properties/NiFiRegistryProperties.java Outdated
*
* @return the property name and network interface name of all HTTPS network interfaces
*/
public Map<String, String> getHttpsNetworkInterfaces() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the only usage of this method does not use the property names, it looks like this could be simplified to just return a Set<String> of interface names that are not blank.

Suggested change
public Map<String, String> getHttpsNetworkInterfaces() {
public Set<String> getHttpsNetworkInterfaceNames() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will simplify

exceptionfactory
exceptionfactory reviewed Feb 9, 2023
View reviewed changes
...try-properties/src/main/java/org/apache/nifi/registry/properties/NiFiRegistryProperties.java Outdated
// determine if the property is a network interface name
if (StringUtils.startsWith(propertyName, WEB_HTTPS_NETWORK_INTERFACE_PREFIX)) {
// get the network interface property value
networkInterfaceNames.add(getProperty(propertyName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can add an empty value to networkInterfaceNames, so this should be adjusted to filter out empty values.

exceptionfactory
exceptionfactory approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the feedback @emiliosetiadarma, the latest version looks good and works as expected! +1 merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emiliosetiadarma @exceptionfactory